[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32522 [Core Tor/Tor]: Create better tooling for canonical tor header includes

#32522: Create better tooling for canonical tor header includes
-------------------------------------------+-------------------------------
 Reporter:  teor                           |          Owner:  teor
     Type:  task                           |         Status:  needs_review
 Priority:  Medium                         |      Milestone:  Tor:
                                           |  0.4.3.x-final
Component:  Core Tor/Tor                   |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  network-team-roadmap-november  |  Actual Points:  5
Parent ID:  #31851                         |         Points:  1
 Reviewer:  nickm                          |        Sponsor:  Sponsor31-can
-------------------------------------------+-------------------------------
Changes (by teor):

 * status:  assigned => needs_review
 * reviewer:   => nickm
 * actualpoints:  4 => 5


Comment:

 Here's my draft pull request:
 * https://github.com/torproject/tor/pull/1578

 And here's what the code actually ends up doing:
 * better canonical header paths
 * delete unused PRIVATE, INTERNAL, and EXPOSE defines
 * delete duplicate includes
 * standardise whitespace (conforming to `make check-spaces`, plus extra
 fixes)
 * add command-line arguments to control which files get which fixes

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32522#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs