[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32609 [Core Tor/Tor]: Improve practracker unit tests, and run them in "make check" and pre-commit

#32609: Improve practracker unit tests, and run them in "make check" and pre-commit
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  test, network-team-roadmap-november  |  Actual Points:  0.4
Parent ID:  #32522                               |         Points:  0.4
 Reviewer:  nickm                                |        Sponsor:
                                                 |  Sponsor31-can
-------------------------------------------------+-------------------------

Comment (by teor):

 See my PR:
 * master: https://github.com/torproject/tor/pull/1565

 It will need to be squashed before merging.

 I went with the simple change, and added the missing .may_include files.
 There are 4 `!advisory` files right now, in
 `core/{crypto,mainloop,or,proto}`. They won't catch "*.c" includes, but
 the others will. That's probably ok for now.

 We can get more specific about the dependencies in future work.

 I documented `!advisory` in practracker/includes.py, because it wasn't
 documented.

 I also fixed an issue in the pre-commit hook, and added checkSpaceTest.sh
 from #32613 to that hook. (Otherwise, there would have been a merge
 conflict.)

 Here's the script I used to create the new .may_include files:
 {{{
 $ cd tor
 $ echo '*.h' > .may_include
 $ for cf in `find src -name *.c`; do
     d=`dirname $cf`
     if [ ! -e $d/.may_include ]; then
         echo $d/.may_include
     fi
   done | sort -u | grep -v ext | xargs -n1 cp .may_include
 $ echo '*.inc' >> src/app/config/.may_include
 $ echo '*.inc' >> src/test/.may_include
 $ rm .may_include
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32609#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs