[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

#28745: THE Torbutton clean-up
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  acat
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton,                       |  Actual Points:
  TorBrowserTeam201912R                          |
Parent ID:  #30506                               |         Points:
 Reviewer:  gk                                   |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Okay, let's move on with the review process, commit
 8269902a22357697c46c7052c9d946bd874c3f55:

 Looks mostly good. It misses a `tor-browser` change to remove the
 `extensions.torbutton.updateNeeded` and
 `extensions.torbutton.versioncheck_enabled` pref, now that we moved the
 preferences. Additionally, please remove the `torbutton-update-needed.svg`
 as well. It seems to be obsolete now, too.

 For 8c0c18a09a30f14dd0b4a99fe67238fec0ad3bac what command did you run/tool
 did you use to check for those errors (and fix them)?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28745#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs