Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#28745: THE Torbutton clean-up
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  acat
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton, TorBrowserTeam201912  |  Actual Points:
Parent ID:  #30506                               |         Points:
 Reviewer:  gk                                   |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:22 acat]:

 [snip]

 > There were some conflicts with the last commit of 28745+2
 (2d318efde8faccf3980c6d7da163c32103202b26) and the
 46efc92348dbed06fc31ddfb0a5ac2e4e8554de2 commit in master (#30237). I
 think these are not straightforward to solve, as in that commit I moved
 `m_tb_control_ipc_file, m_tb_control_host, m_tb_control_port,
 m_tb_control_pass, m_tb_control_desc` to a service while in the master
 commit those were moved to a different module and initialized via
 `configureControlPortModule`. I would suggest dropping that commit for
 now, and perhaps do it later in #30850 (some of the previous dropped
 commits are also related to that one).

 Sounds good to me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28745#comment:30>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs