[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32480 [Applications/GetTor]: Use Github/Gitlab releases to distribute gettor binaries

#32480: Use Github/Gitlab releases to distribute gettor binaries
---------------------------------+-----------------------------
 Reporter:  cohosh               |          Owner:  cohosh
     Type:  defect               |         Status:  merge_ready
 Priority:  Medium               |      Milestone:
Component:  Applications/GetTor  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:  github, releases     |  Actual Points:  1
Parent ID:                       |         Points:  1
 Reviewer:  phw                  |        Sponsor:
---------------------------------+-----------------------------
Changes (by phw):

 * status:  needs_review => merge_ready


Comment:

 Looks good to me! I only had a minor nitpick, which I left in the code.
 Putting the authentication token into an environment variable seems like a
 good solution.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32480#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs