[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30558 [Applications/Tor Browser]: Namecoin support for onion sites in Tor Browser
#30558: Namecoin support for onion sites in Tor Browser
--------------------------------------+--------------------------------
Reporter: arthuredelstein | Owner: JeremyRand
Type: defect | Status: needs_revision
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam201912 | Actual Points:
Parent ID: | Points:
Reviewer: gk | Sponsor:
--------------------------------------+--------------------------------
Comment (by gk):
Replying to [comment:36 JeremyRand]:
> Did I say a day? I must have meant 37 minutes. :)
>
> Updated branch at https://notabug.org/JeremyRand/tor-browser-
build/src/namecoin-v3 (Git commit hash
`400bf48791c508afe8014c0fb949f61a7224b33a`).
Thanks. commit 5db1d985c4339f81fb30d0fccd8f8945af3902ca looks almost good
now.
In `electrum-nmc`'s build script you have
{{{
+distdir=/var/tmp/build/[% project %]
}}}
but you don't use `distdir` anywhere, please remove that.
One typo in `roots_of_top_10_issuers.pem` s/root CA's/root CAs/.
For commit 644893e115e3d160fca5ced763a7ebbd018f1a0e
Some trailing whitespace to remove on
{{{
+ export CGO_ENABLED=[% c("var/cgo") %]
}}}
in `ncprop279/config` and
{{{
+ go_lib_deps:
}}}
in `gokingpin/config`.
In the same vein as comment:26 1): Please remove all the non-Linux parts
and the conditional Linux includes. That's not needed for our PoC here.
Some of those parts seem to be wrong as well (e.g. you have `var/cgo` only
for Linux declared in `ncdns/config`; however in the corresponding build
script you check for `var/osx` *in* the `var/cgo` block but that code is
never reached) and I think we should not include code we currently don't
test/exercise in any way.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30558#comment:37>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs