[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30558 [Applications/Tor Browser]: Namecoin support for onion sites in Tor Browser
#30558: Namecoin support for onion sites in Tor Browser
--------------------------------------+--------------------------------
Reporter: arthuredelstein | Owner: JeremyRand
Type: defect | Status: needs_revision
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam201912 | Actual Points:
Parent ID: | Points:
Reviewer: gk | Sponsor:
--------------------------------------+--------------------------------
Comment (by JeremyRand):
> but you don't use distdir anywhere, please remove that.
Good point; will fix that.
> One typo in roots_of_top_10_issuers.pem s/root CA's/root CAs/.
AFAIK it's common practice (though not universal) in English to form
plurals of initialisms, letters, and numbers by appending an apostrophe
followed by an "s". DuckDuckGoing for `initialisms plural apostrophe`
seems to indicate that this choice varies by writer, and is neither
required nor erroneous. If you really want the apostrophe to be removed,
let me know and I'll do it, but it wasn't unintentionally included.
> Some trailing whitespace to remove on
Good catch, I'll fix that.
> Please remove all the non-Linux parts and the conditional Linux
includes.
Okay.
> (For the macOS parts it's worth to keep in mind that we have
macosx_deployment_target: '10.9' and not 10.7 anymore. We only support
macOS 10.9 and onward.)
Ah, somehow I missed that. I'll fix that in Namecoin's version of the rbm
scripts (even though it's not relevant for this patchset since this
patchset is Linux-only), since we do build for macOS for our binaries, and
we try to follow Tor's conventions on this stuff.
I'll post an updated branch shortly.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30558#comment:39>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs