Re: [tor-bugs] #30558 [Applications/Tor Browser]: Namecoin support for onion sites in Tor Browser

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#30558: Namecoin support for onion sites in Tor Browser
--------------------------------------+--------------------------------
 Reporter:  arthuredelstein           |          Owner:  JeremyRand
     Type:  defect                    |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201912      |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:  gk                        |        Sponsor:
--------------------------------------+--------------------------------

Comment (by gk):

 Replying to [comment:40 JeremyRand]:
 > Updated branch at https://notabug.org/JeremyRand/tor-browser-
 build/src/namecoin-v4 (Git commit hash
 `a37eb03fc88f192aa02f4694468effa47de53a49`).

 Commit 53279791b5a332df99215199c3040d517620a91d looks good now (I am fine
 with keeping `CA's`).
 Commit a5fd87e61a53e3bceec638758f8d65ba61798468:

 There are a bunch of things to note in no particular order:

 a) In `gobtcd`: Why is there `build_go_lib_pre` defined? What does that
 do? Building `ncprop279` without it works perfectly fine for me.

 b) Why is `gobtcd` and `gobtcd2` split? Is that because `gobtcd` depends
 on `gobtcutil` which depends on `gobtcd2`? How does the compilation of
 that work outside `tor-browser-build` as I can't imagine that this
 circular dependency is not an issue there as well? If you can't work
 around that (i.e. have only one `gobtcd` project) then please add a
 comment, probably in the `gobtcd2` project, explaining the problem.

 c) `gowinsvc` is not needed, please remove it.

 d) `ncdns`: `os_go_lib_deps` is empty, please remove it and the respective
 for-loop in the build script.

 e) `ncdns`: `+#mkdir -p /var/tmp/build` etc. is commented out but not
 needed, please remove it.

 f) `ncdns`: what is
 {{{
 +[% IF c("var/linux-x86_64") -%]
 +  GOPATHBIN="${GOPATH}/bin"
 +[% ELSE -%]
 +  GOPATHBIN="${GOPATH}/bin/${GOOS}_${GOARCH}"
 +[% END -%]
 }}}
 doing at that place in the build script as you are not building after it
 anymore? The same goes for `+# Build as library`.

 g) `ncdns`: the `goxlog` dependency does not seem to be needed, please
 remove it.

 h) `ncprop279`: there is a bunch of comments in the build script which are
 not needed, starting
 with `+#mkdir -p /var/tmp/build`; please remove them.

 i) `ncprop279`: what does
 {{{
 +[% IF c("var/linux-x86_64") -%]
 +  GOPATHBIN="${GOPATH}/bin"
 +[% ELSE -%]
 +  GOPATHBIN="${GOPATH}/bin/${GOOS}_${GOARCH}"
 +[% END -%]
 +
 +ls $GOPATHBIN
 }}}
 do?

 j) `+export CGO_ENABLED=[% c("var/cgo") %]` <- no need for having that
 exported as `cgo` seems to be `0`. Thus, you can remove all the `cgo`
 related things.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30558#comment:41>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs