[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32172 [Core Tor/Tor]: port test suite to Android to run in emulator

#32172: port test suite to Android to run in emulator
---------------------------------+------------------------------------
 Reporter:  eighthave            |          Owner:  (none)
     Type:  task                 |         Status:  needs_revision
 Priority:  Medium               |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor         |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:  Android, tbb-mobile  |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:  ahf                  |        Sponsor:
---------------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Ahh, it looks like your current patch is much simpler:
 {{{
 +#elif defined(__ANDROID__)
 +  /* tor might not like the default perms, so create a subdir */
 +  tor_snprintf(temp_dir, sizeof(temp_dir),
 +               "/data/local/tmp/tor_%d_%d_%s",
 +               (int) getuid(), (int) getpid(), rnd32);
 +  r = mkdir(temp_dir, 0700);
 +  if (r) {
 +    fprintf(stderr, "Can't create directory %s:", temp_dir);
 +    perror("");
 +    exit(1);
 }}}


 This is a lot more reasonable than what was in the branch before.  I'll
 see if I can extract that into something mergeable.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32172#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs