[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31834 [Circumvention]: Make obfs4 Docker image more usable
#31834: Make obfs4 Docker image more usable
-------------------------------+-------------------------------
Reporter: phw | Owner: phw
Type: defect | Status: closed
Priority: Medium | Milestone:
Component: Circumvention | Version:
Severity: Normal | Resolution: fixed
Keywords: docker, s30-o24a2 | Actual Points: 1.1
Parent ID: #31281 | Points: 1
Reviewer: cohosh | Sponsor: Sponsor30-can
-------------------------------+-------------------------------
Comment (by phw):
Replying to [comment:22 thymbahutymba]:
> Replying to [comment:21 phw]:
> > Am I missing something?
>
> I'm point just the fact that if somebody for some reason has to change
the port he loose not only its users but also its seniority.
[[br]]
Right, apart from users, the operator would also give up the bridge's
statistics (if they were sent to metrics).
[[br]]
> I would also let you know that there is an issue in the get-bridge-line
script, due to the fact that the log might contains multiple "reboot" of
the docker container with the same line repeated multiple times, this is a
mess once someone has to run the script because ends up in a plenty of
meaningless lines before the final result. I think that in order to do fix
this after the {{{sed}}} command can be piped the {{{tail}}} command in
order to get the last line. For example:
> {{{
> $(grep '...' "$TOR_LOG" | sed "..." | tail -1)
> }}}
[[br]]
Nice catch! I added a fix [https://dip.torproject.org/torproject/anti-
censorship/docker-
obfs4-bridge/commit/bdbd79484fd27a1d0dbf71c37bad6d16cd2cdb89 in this
commit]. Does it look good to you?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31834#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs