Re: [tor-bugs] #30558 [Applications/Tor Browser]: Namecoin support for onion sites in Tor Browser

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#30558: Namecoin support for onion sites in Tor Browser
--------------------------------------+--------------------------------
 Reporter:  arthuredelstein           |          Owner:  JeremyRand
     Type:  defect                    |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201912      |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:  gk                        |        Sponsor:
--------------------------------------+--------------------------------

Comment (by JeremyRand):

 > g) ncdns: the goxlog dependency does not seem to be needed, please
 remove it.

 `ncprop279` imports `github.com/namecoin/ncdns/backend`, which imports
 `github.com/hlandau/xlog`.  So I think it's appropriate to have `goxlog`
 as a dependency of `ncdns`.  I suspect that `goxlog` is getting pulled in
 via another dependency (probably `godexlogconfig`) as well, which I
 suppose means that it will build without errors if `goxlog` is omitted
 from `ncdns`, but I don't think it's a good idea to omit it from `ncdns`'s
 dependencies, since it's directly imported from an `ncdns` package.  But,
 if you really want me to omit `goxlog` from `ncdns`'s dependencies, let me
 know and I'll do it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30558#comment:43>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs