[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30558 [Applications/Tor Browser]: Namecoin support for onion sites in Tor Browser
#30558: Namecoin support for onion sites in Tor Browser
--------------------------------------+--------------------------------
Reporter: arthuredelstein | Owner: JeremyRand
Type: defect | Status: needs_revision
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam201912 | Actual Points:
Parent ID: | Points:
Reviewer: gk | Sponsor:
--------------------------------------+--------------------------------
Comment (by gk):
Replying to [comment:45 JeremyRand]:
> Updated branch at https://notabug.org/JeremyRand/tor-browser-
build/src/namecoin-v5 (Git commit hash
`76d09f1d7dd8ecc24ab9d4eb8356ac5e4d95d776`).
Thanks, the changes you made compared to -v4 look good to me. It feels we
are getting pretty close here. In commit
e32a739ea11a06880f0e411708796b2f2a2e9270 you have:
{{{
+ # Strip off the version number from the Electrum-NMC directory name
+ mv $TBDIR/TorBrowser/Electrum-NMC* $TBDIR/TorBrowser/Electrum-NMC
}}}
We should not do that here. Rahther, please include that into the
respective commit where all the Electrum-NMC code gets added. Looking back
at that commit I see you have
{{{
+cp -a /var/tmp/build/[% project %]/[% project %]* ./Electrum-NMC-[%
c('version') %]
+
+cd ./Electrum-NMC-[% c('version') %]
}}}
Couldn't you do something like
{{{
+cp -a /var/tmp/build/[% project %]/[% project %]* ./Electrum-NMC
+
+cd ./Electrum-NMC
}}}
instead?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30558#comment:46>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs