[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31130 [Applications/Tor Browser]: Use Debian 10 for our Android container images
#31130: Use Debian 10 for our Android container images
-------------------------------------------+--------------------------
Reporter: gk | Owner: sisbell
Type: defect | Status: reopened
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-rbm, TorBrowserTeam201912 | Actual Points: 1
Parent ID: #31127 | Points: 0.5
Reviewer: gk | Sponsor:
-------------------------------------------+--------------------------
Comment (by gk):
Replying to [comment:63 boklm]:
> Replying to [comment:62 boklm]:
> > The patch that was merged causes the build of go to fail with:
>
> The patch was based on an old commit, before #28803 (which I think added
the dependency on go).
Ah, that makes sense. I remember building everything end-to-end but forgot
to build everything again. There are a bunch of lessons to learn here (for
the reviewer and the patch writer ;) ), like base your final patch on the
latest code in `master` and test it on the latest code in `master`, too...
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31130#comment:64>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs