[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30558 [Applications/Tor Browser]: Namecoin support for onion sites in Tor Browser
#30558: Namecoin support for onion sites in Tor Browser
--------------------------------------+--------------------------------
Reporter: arthuredelstein | Owner: JeremyRand
Type: defect | Status: needs_revision
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam201912 | Actual Points:
Parent ID: | Points:
Reviewer: gk | Sponsor:
--------------------------------------+--------------------------------
Comment (by JeremyRand):
Good to hear that the previously reported issues were related to the
Ctrl+C killing.
Regarding (1): I suspect that this is because Electrum-NMC has tried to
open a connection to a server while Tor was still connecting, and the
result is that the server isn't reachable, so the TCP connection times
out. It's possible that we could decrease the timeout period in Electrum-
NMC, which might improve the behavior here. However, decreasing it too
far might cause it to prematurely give up on low-quality Tor circuits.
I'll get back to you on this later today. (Longer-term, it might be
productive to have Electrum-NMC talk to the Tor control port so that it
knows when the network is up, which would allow it to avoid trying to make
connections while Tor is still connecting. This would be a more
complicated fix than fiddling with the timeouts though, so I'd prefer not
to attempt this prior to a Nightly merge unless further testing indicates
that it's absolutely necessary.)
Regarding (2): StemNS will retry a lookup that failed with SERVFAIL for up
to 1 minute before giving up completely on that lookup. This is because a
SERVFAIL error is often an indication of a temporary network issue, and it
will usually fix itself if retried a few times. Unfortunately, there's a
bug in upstream Electrum that causes errors that should be detected as
NXDOMAIN (which won't be retried) to instead be detected as SERVFAIL
(specifically, Electrum doesn't properly set the JSON-RPC error variables
in responses). AFAIK upstream Electrum fixed this in their master branch
sometime after 3.3.8 was tagged (due to me sending in a bug report). I'm
pretty sure that directly backporting Electrum's fix to 3.3.8 would be
prohibitively difficult (their fix was part of a large refactor of the
JSON-RPC code which will almost definitely produce merge conflicts if
cherry-picked to 3.3.8), but I might be able to do a much simpler fix to
the 3.3.8 branch of Electrum-NMC. Again, I'll get back to you on this
later today.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30558#comment:56>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs