[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32135 [Metrics/Statistics]: Write BridgeDB metrics parser and analyse existing data

#32135: Write BridgeDB metrics parser and analyse existing data
--------------------------------+--------------------------------
 Reporter:  phw                 |          Owner:  phw
     Type:  task                |         Status:  needs_review
 Priority:  Medium              |      Milestone:
Component:  Metrics/Statistics  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:  s30-o21a1           |  Actual Points:
Parent ID:  #31274              |         Points:  2
 Reviewer:                      |        Sponsor:  Sponsor30-must
--------------------------------+--------------------------------
Changes (by karsten):

 * status:  needs_revision => needs_review


Comment:

 I pushed a [https://gitweb.torproject.org/user/karsten/metrics-
 web.git/commit/?h=task-32135&id=4046d70de975d502e20c38e4cdb671eb41b300c6
 squash commit] where I made a few changes and tried to include most of
 your suggestions. Please take a look if you can.

 A few comments on that:

  - I kept the term "transport" and used "distributor" instead of
 "distribution (method)".

  - The current graph names are "BridgeDB requests by requested transport"
 and "BridgeDB requests by distributor". If we can keep the "by" instead of
 "for each", I'd prefer that. I put in the "requested" to avoid confusions
 with a hypothetical statistic on requests coming in via different
 transport. If you think that it would be clear enough without the
 "requested" part, we can take that out, too.

  - There are two `TODO`s left in the sources. If you have suggestions for
 useful text there, I'd gladly put that in. Otherwise I can make something
 up.

 Regarding code review, I don't think we'll get one before the holidays.
 But this code is separate from other code, so I'd say it's fine to deploy
 it anyway. Worst thing that can happen is that the numbers aren't correct,
 but I think that you would be the best person to notice that. The code
 review by irl would then happen in January, and if I screwed up something,
 I'd fix that then.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32135#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs