[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #2434 [Tor Relay]: Don't disable dirport when accounting limit can't be reached due to bwrate
#2434: Don't disable dirport when accounting limit can't be reached due to bwrate
-----------------------+----------------------------------------------------
Reporter: Sebastian | Owner:
Type: defect | Status: needs_review
Priority: normal | Milestone: Tor: 0.2.3.x-final
Component: Tor Relay | Version:
Keywords: | Points:
Parent: |
-----------------------+----------------------------------------------------
Comment(by arma):
Looks reasonable.
My first minor suggestion would be to put a comment in the code as to why
we have that extra case, and a short comment in the changes file saying
what that lets you do.
Second minor suggestion would be to switch the
accounting_set_wakeup_time() function to use your new
accounting_get_interval_length() abstraction rather than its
time_in_interval variable.
The broader suggestion would be, if we want an alternate more explicit way
to do this (rather than relying on a hack), to have another torrc option
(e.g. AccountingTrack) which explicitly says to do all the accounting
stuff but not for hibernating. I don't think this change is a big enough
deal to matter either way though.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2434#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs