[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #2186 [Vidalia]: Vidalia can't handle blank CountrySummary= arg in Bridge History

#2186: Vidalia can't handle blank CountrySummary= arg in Bridge History
--------------------------------+-------------------------------------------
  Reporter:  say.hello.to.anna  |              Owner:  chiiph      
      Type:  defect             |             Status:  needs_review
  Priority:  normal             |          Milestone:              
 Component:  Vidalia            |            Version:              
  Keywords:                     |             Parent:              
    Points:                     |   Actualpointsdone:              
Pointsdone:                     |       Actualpoints:              
--------------------------------+-------------------------------------------

Comment(by edmanm):

 Meh, Sebastian's patch kinda sucks for the reasons he noted above. There's
 already code for a dialog box in that with the "hey sorry, no bridge users
 yet" message, so why not reuse it rather than displaying an empty user
 table? In theory, I like the patch I attached better, but I haven't been
 able to reproduce the blank !CountrySummary line (I didn't try too hard)
 so I haven't been able to test it. If someone who can reproduce the black
 !CountrySummary wants to give it a try, that'd be handy.

 And the answer to the mystery noted in your patch and comment above is
 because QString's default split behavior is `QString::KeepEmptyParts`.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2186#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs