[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #2611 [Vidalia]: Remove OpenSSL dependency
#2611: Remove OpenSSL dependency
-------------------------+--------------------------------------------------
Reporter: chiiph | Owner: chiiph
Type: enhancement | Status: needs_review
Priority: major | Milestone:
Component: Vidalia | Version:
Keywords: | Parent:
Points: | Actualpoints:
-------------------------+--------------------------------------------------
Comment(by edmanm):
I don't understand how you concluded that Vidalia doesn't need OpenSSL
anymore. The code that downloads bridge addresses automatically for users
obviously uses SSL to do so. The (currently unused) code that uploads
Breakpad crash dumps uses SSL to do so. Just grep for `QSslSocket` and you
can see this. If you ship a Vidalia package on Windows with a Qt that
doesn't have OpenSSL static-linked into it (and the user doesn't already
have OpenSSL installed in their `%PATH%`), then this patch is going to
break Vidalia distributions on Windows.
That said, the portions of this patch related to removing the
`TorSslSocket` class and `USE_QSSLSOCKET` `#define` are good. I'm
surprised that stuff is still in there. I thought I had removed it awhile
ago. `ZlibByteArray` and all zlib-related stuff could go, too.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2611#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs