Re: [tor-bugs] #5069 [Obfsproxy]: obfsproxy log file has no timestamps

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#5069: obfsproxy log file has no timestamps
-----------------------+----------------------------------------------------
 Reporter:  arma       |          Owner:  asn         
     Type:  defect     |         Status:  needs_review
 Priority:  normal     |      Milestone:              
Component:  Obfsproxy  |        Version:              
 Keywords:             |         Parent:              
   Points:             |   Actualpoints:              
-----------------------+----------------------------------------------------

Comment(by karsten):

 Replying to [comment:2 arma]:
 > It should be <time.h>, not "time.h". <> is for system headers, and "" is
 for your own headers.

 Fixed.

 > When you call strftime, you should say sizeof(ts) rather than 21.
 Otherwise you're asking for troubles later when somebody changes one 21
 but not the other.

 Fixed.

 > Why do you have a T in the middle of the timestamp, and a Z at the end?
 The Z might be for Zulu I guess?

 T is the delimiter.  Wikipedia says there's a delimiter in ISO 8601.  I
 think if we want to use the Z we should also use the T.  Z is Zulu time.

 See new patch attached to this ticket.  Thanks for the code review!

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5069#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs