[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
[tor-bugs] #5075 [Obfsproxy]: obfsproxy is too gentle during assertion failures
#5075: obfsproxy is too gentle during assertion failures
-----------------------+----------------------------------------------------
Reporter: asn | Owner: asn
Type: defect | Status: new
Priority: normal | Milestone:
Component: Obfsproxy | Version:
Keywords: | Parent:
Points: | Actualpoints:
-----------------------+----------------------------------------------------
This is part of #3613 that never got fixed:
{{{
/** Assertion checking. We don't ever compile assertions out, and we
want precise control over the error messages, so we use our own
assertion macros. */
#define obfs_assert(expr) \
do { \
if (!(expr)) \
log_error("assertion failure at %s:%d: %s", \
__FILE__, __LINE__, #expr); \
} while (0)
#define obfs_abort() \
do { \
log_error("aborted at %s:%d", __FILE__, __LINE__); \
} while (0)
}}}
and `log_error()` is:
{{{
/** Public function for logging an error and then exiting. */
void
log_error(const char *format, ...)
{
va_list ap;
va_start(ap,format);
logv(LOG_SEV_ERR, format, ap);
va_end(ap);
exit(1);
}
}}}
This won't dump cores or backtraces back to the user.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5075>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs