[tor-bugs] #5139 [Tor Bridge]: Bogus comment in router_rebuild_descriptor

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#5139: Bogus comment in router_rebuild_descriptor
------------------------+---------------------------------------------------
 Reporter:  rransom     |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Bridge  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
 From `router_rebuild_descriptor` in src/or/router.c:
 {{{
   ri->purpose =
     options->BridgeRelay ? ROUTER_PURPOSE_BRIDGE : ROUTER_PURPOSE_GENERAL;
   ri->cache_info.send_unencrypted = 1;
   /* Let bridges serve their own descriptors unencrypted, so they can
    * pass reachability testing. (If they want to be harder to notice,
    * they can always leave the DirPort off). */
   if (ei && !options->BridgeRelay)
     ei->cache_info.send_unencrypted = 1;
 }}}

 This comment doesn't quite match the behaviour of the code.  Also, a
 bridge's DirPort option is now forced off.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5139>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs