[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
[tor-bugs] #5178 [Tor Client]: Adaptive circuit-build timeout code does not match spec
#5178: Adaptive circuit-build timeout code does not match spec
------------------------+---------------------------------------------------
Reporter: rransom | Owner:
Type: defect | Status: new
Priority: major | Milestone: Tor: 0.2.2.x-final
Component: Tor Client | Version:
Keywords: | Parent:
Points: | Actualpoints:
------------------------+---------------------------------------------------
{{{
01:37 < rransom_> wanoskarnet: See section 2.4.4 of path-spec.txt in
https://gitweb.torproject.org/torspec.git/tree . Does that match the
behaviour in the code? Is that behaviour good?
01:43 < wanoskarnet> numbers are different. idea is fine except definition
of networkk connectivity loss. and no double the timeout can happen
because it reset number of counts and could count abandoned circuit if
counted of success circ.
01:44 < wanoskarnet> "was already 60 or higher" "or higher" actually means
changed initial values only. but it's ok to check for such case.
01:46 < wanoskarnet> in oter work: code do reset timeout to init values
but can't double timeout.
01:55 < wanoskarnet> circuit_build_times_network_check_live() non the same
as "2.4.4". cbt->liveness.nonlive_timeouts incremeants just after "we've
received no cells or TLS handshakes since those circuits began." no matter
what number of timeouts.
01:57 < wanoskarnet> "if (cbt->liveness.nonlive_timeouts > 0)" should be
3?
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5178>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs