[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #1667 [Tor Client]: Give a more appropriate "I'm not an HTTP proxy" message when we get an HTTP request on the control port

#1667: Give a more appropriate "I'm not an HTTP proxy" message when we get an HTTP
request on the control port
----------------------------+-----------------------------------------------
    Reporter:  nickm        |       Owner:                  
        Type:  enhancement  |      Status:  needs_revision  
    Priority:  trivial      |   Milestone:  Tor: unspecified
   Component:  Tor Client   |     Version:                  
  Resolution:               |    Keywords:  easy            
      Parent:               |      Points:                  
Actualpoints:               |  
----------------------------+-----------------------------------------------
Changes (by nickm):

  * status:  needs_review => needs_revision


Comment:

 I think we want to send back an HTTP response, not a raw string, right?

 We don't want to do this unless the GET/POST/CONNECT/DELETE/whatever comes
 as the first thing on the control port; I think this patch might make a
 GET/POST/CONNECT get treated as HTTP at any point on the control port.

 Connection_mark_and_flush() seems right here; we don't want to close the
 connection until it is done flushing.

 We usually write multiline strings as "a string on one line\n"
  "followed by a string on another line\n".

 Let's try to get something like this into 0.2.4.x?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1667#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs