[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #1667 [Tor Client]: Give a more appropriate "I'm not an HTTP proxy" message when we get an HTTP request on the control port
#1667: Give a more appropriate "I'm not an HTTP proxy" message when we get an HTTP
request on the control port
----------------------------+-----------------------------------------------
Reporter: nickm | Owner:
Type: enhancement | Status: needs_review
Priority: trivial | Milestone: Tor: unspecified
Component: Tor Client | Version:
Resolution: | Keywords: easy
Parent: | Points:
Actualpoints: |
----------------------------+-----------------------------------------------
Changes (by neena):
* status: needs_revision => needs_review
Comment:
Replying to [comment:10 rransom]:
> According to the message which Tor's SOCKSPort emits when someone
attempts to use it as an HTTP proxy/server, you need to send a larger
response in order to ensure that Internet Explorer will display it.
Looked at it. It helped me understand a lot of things.
Also, used the same message, with a few modifications.
> Now the control port will silently eat commands with certain names. It
should send a reply.
>
> This still might send an HTTP-like response even if the HTTP-request-
like line isn't the first thing send on a connection.
I misunderstood something the last time. Should be right now.
> `strcasecmp` should be the wrong function. Perhaps you want
`strcasecmpstart`?
Used a switch-case, like the "Tor is not an HTTP Proxy" code instead.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1667#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs