[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #5053 [Tor Bridge]: Fix IPv6 implementation for bridge statistics
#5053: Fix IPv6 implementation for bridge statistics
------------------------+---------------------------------------------------
Reporter: karsten | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: Tor: 0.2.3.x-final
Component: Tor Bridge | Version:
Keywords: | Parent:
Points: | Actualpoints:
------------------------+---------------------------------------------------
Comment(by ln5):
Looks very good to me. With tests and all!
A few comments:
- I would've collapsed more of the functions into one too,
f.ex. geoip_get_country_by_ip() by adding a 'family' argument.
- I'd renamed data types, lists and functions specific to IPv4 (like
struct geoip_entry_t) but I'd like to hear others view on this.
- There's tor_addr_compare() which I think should be used instead of
memcmp().
- A comment or two in geoip_get_client_history() explaining how this
works for both IPv4 and IPv6 would be nice but not necessary.
- Remove prototype for geoip_load_ipv6_file() in geoip.h.
Coding style:
- I don't think we do 'if (foo) bar;' without a newline.
- A few whitespace changes should go away (geoip.c:346, geoip.c:497,
test.c:1479, test.c:1516).
I think Nick should take a look at this too before merging.
I will run this on my IPv6 bridge and see how it works.
Thanks!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5053#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs