[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #5207 [Ooni]: ooni-probe should only set UseMicrodescriptors 0 if Tor understands that option

#5207: ooni-probe should only set UseMicrodescriptors 0 if Tor understands that
option
------------------------+---------------------------------------------------
    Reporter:  karsten  |       Owner:  hellais 
        Type:  defect   |      Status:  reopened
    Priority:  normal   |   Milestone:          
   Component:  Ooni     |     Version:          
  Resolution:           |    Keywords:          
      Parent:  #5028    |      Points:          
Actualpoints:           |  
------------------------+---------------------------------------------------
Changes (by karsten):

  * status:  closed => reopened
  * resolution:  fixed =>


Comment:

 Minor bug in ea2083a: `tor_greater_than('0.2.2')` causes an ERROR: "Error
 in parsing your Tor version string: Tor version 0.2.2.35 (git-
 73ff13ab3cc9570d)."  Looks like that function requires 4 ints, not just 3.
 Also, the right version to compare with is 0.2.3.2, not 0.2.2.x.  Change
 that code to `tor_greater_than('0.2.3.2')`, and it'll work just fine.

 Here's a comment that you could add to explain why we compare to 0.2.3.2:
 "The UseMicrodescriptors torrc option was first introduced in
 0.2.3.2-alpha with a default value of 0.  Earlier versions don't
 understand that option.  0.2.3.3-alpha was the first version that required
 explicitly setting UseMicrodescriptors 0 to go back to old-style consensus
 and descriptors, which is what we want here.  Hence, set that option only
 in versions greater than 0.2.3.2."

 Also, it's kinda annoying to read the WARN message "You run an outdated
 version of Tor: Tor version 0.2.2.35 (git-73ff13ab3cc9570d). (< 0.2.3.2)"
 for every tested bridge.  We look at the version string only to say
 whether Tor will understand the UseMicrodescriptors torrc option, not to
 check if it's recent enough to run our test.  Maybe the WARN message
 should only be emitted outside of `tor_greater_than` if the caller isn't
 happy with the result.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5207#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs