[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #2149 [Tor]: new 'extra dormant' mode for people who never use their tor
#2149: new 'extra dormant' mode for people who never use their tor
--------------------------------------------+-------------------------------
Reporter: arma | Owner:
Type: enhancement | Status: needs_revision
Priority: major | Milestone: Tor: 0.2.5.x-final
Component: Tor | Version:
Keywords: performance scaling tor-client | Parent:
Points: | Actualpoints:
--------------------------------------------+-------------------------------
Changes (by nickm):
* status: needs_information => needs_revision
Comment:
Replying to [comment:22 sysrqb]:
> Thanks to both of you for the review. (I'm sorry this ticket is such a
mess)
>
> Replying to [comment:21 nickm]:
[...]
> > * We should make sure that new DNS requests count as client activity
>
> I don't think this currently does. It looks like we need to catch
requests in dnsserv.c:evdns_server_callback(), i think?
That seems right.
> > * The interval needed to become dormant should be configurable, for
testing if nothing else.
>
> Yeah, I was doing this by hand. Torrc option AllowEnterDormancy? Values
> 0 define time period the client must be inactive, 0 disables this
feature?
Sounds good. How about calling it BecomeDormantAfter ?
> > * We should make sure that hidden services can never go dormant, and
that adding a hidden service makes a node non-dormant.
>
> I was relying on server_mode() to determine if Tor was an OP or OR. TBH
I didn't check if it considered Hidden Services. I just took a look and I
gathered that we can check that rend_service_list == NULL, is there a
better way to do it?
Calling num_rend_services() is one way; I don't know if there's a better
one.
> > * We should be consistent about invoking
directory_too_idle_to_fetch_consensuses() versus testing Dormant directly.
>
> I'm having trouble remembering the specific case for this. It had to do
with a variable not be initialized until later in bootstrapping but either
I can't find it now or I missed something before.
Okay; let's try to figure out what's going on here.
(I tried to skip over issues where there were no questions; please let me
know if I missed something important)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2149#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs