[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #3944 [Tor bundles/installation]: TBB prefs are set as user_prefs (may cause exceptions/settings errors?)

#3944: TBB prefs are set as user_prefs (may cause exceptions/settings errors?)
---------------------------------------+------------------------------------
 Reporter:  mikeperry                  |          Owner:  erinn                        
     Type:  defect                     |         Status:  new                          
 Priority:  major                      |      Milestone:  TorBrowserBundle 2.3.x-stable
Component:  Tor bundles/installation   |        Version:                               
 Keywords:  tbb-bounty, tbb-usability  |         Parent:                               
   Points:                             |   Actualpoints:                               
---------------------------------------+------------------------------------

Comment(by mikeperry):

 I've been testing this and cleaning up our prefs a bit. It seems to be
 good so far, but one thing I've noticed with the Torbutton patch is that
 you didn't change the torbutton's update of the browser.startup.homepage
 pref to use setComplexValue. I went ahead and added that in. It seems to
 work, but probably needs more testing:
 https://gitweb.torproject.org/mikeperry/torbutton.git/commitdiff/aeb7ba1d950104d2e6565ea6611678f441de53e7

 Let me know if there's some reason we shouldn't also use setComplexValue
 there.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3944#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs