[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #2267 [Tor]: resolve_my_address() resolves incorrect address.
#2267: resolve_my_address() resolves incorrect address.
--------------------------------+-------------------------------------------
Reporter: eric225125 | Type: defect
Status: needs_review | Priority: normal
Milestone: Tor: 0.2.4.x-final | Component: Tor
Version: | Resolution:
Keywords: tor-relay | Parent:
Points: | Actualpoints:
--------------------------------+-------------------------------------------
Comment(by nickm):
Replying to [comment:20 nickm]:
> d3695ea0ad04e looks good.
>
> In the other commit (d8f3a49060d), where you log "METHOD=%s %s%s),
there's going to be an extra space sometimes. That'll be easy to fix.
>
> The call to resolve_my_address in check_descriptor_ipaddress_changed()
didn't get a "if (!hostname) hostname = tor_dup_ip(addr)" like the other
calls did. Should it?
Oh, nevermind: hostname was NULL there.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2267#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs