[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12538 [Tor]: Make all relays automatically be dir caches

#12538: Make all relays automatically be dir caches
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:
  cypherpunks            |     Status:  needs_review
         Type:  task     |  Milestone:  Tor: 0.2.6.x-final
     Priority:  normal   |    Version:  Tor: unspecified
    Component:  Tor      |   Keywords:  tor-guard, tor-relay, prop237,
   Resolution:           |  026-triaged-1, sebastian-review
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by sysrqb):

 Replying to [comment:28 nickm]:
 > Re-reviewing based on the `git diff master...` output:
 >
 >  * directory_fetches_from_authorities() has a semantic change that seems
 wrong in the replacement of me->dir_port.  But now I see that
 dir_server_mode() is not quite the same...
 >

 yes and yes. The semantic change was wrong, I think I made it correct now,
 though. dir_server_mode did change slightly since the last the you looked
 at this -  now we confirm we think we have enough available bandwidth
 before we advertise we're a dircache.

 >  * In the router.c changes, are we at any risk of having bridges _not_
 be directory caches?  Bridges all need to be dircaches.
 >

 No, I don't think so. I re-reviewed the changes and I don't see anything
 that impacts the bridge logic. As a sanity check I ran a bridges and it
 accepted and responded to tunneled dir connections without a problem.

 >  * Shouldn't the documentation for supports_tunnelled_dir_requests say
 it's also set if `dir_port > 0`?
 >

 Yes. Corrected.

 > Otherwise this looks ok to me now.

 Great! But now things are changing slightly, but not too much, I hope.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12538#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs