[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9321 [Tor]: Load balance right when we have higher guard rotation periods

#9321: Load balance right when we have higher guard rotation periods
-------------------------+-------------------------------------------------
     Reporter:  arma     |      Owner:
         Type:  project  |     Status:  needs_review
     Priority:  major    |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  needs-proposal, tor-auth, tor-
Actual Points:           |  client, 026-triaged-1, unfrozen, nickm-review
       Points:           |  Parent ID:  #11480
-------------------------+-------------------------------------------------

Comment (by asn):

 BTW, there is now this code in `options_validate()`:
 {{{
     /* same for guardfraction file */
     if (options->GuardfractionFile && !old_options) {
       file_status_t fs = file_status(options->GuardfractionFile);
       if (fs == FN_EMPTY) {
         REJECT("GuardfractionFile set but it's an empty file? Failing");
       } else if (fs != FN_FILE) {
         REJECT("GuardfractionFile set but not a file? Failing");
       }

       dirserv_read_guardfraction_file(options->GuardfractionFile, NULL);
     }
   }
 }}}

 Nick, do you think we should be less strict and not `REJECT` if we can't
 find the file?
 We could just issue a warning and proceed with our business, without
 considering guard fraction at all.

 This seems to be the behavior of the `V3BandwidthsFile` option, and it
 might be better because Tor won't refuse to start if the guardfraction
 script is misbehaving and doesn't output a file.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9321#comment:42>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs