[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #14478 [Tor]: Zero length keys test improvements

#14478: Zero length keys test improvements
-----------------------------+--------------------------------
     Reporter:  cypherpunks  |      Owner:
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor          |    Version:  Tor: unspecified
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------
Changes (by Sebastian):

 * status:  needs_revision => needs_review


Comment:

 Hrm, I'm not seeing how we can do any kind of sane checking of the string
 returned by mktemp. If the command invocation fails and it is empty, I am
 returning an error and a log message. I don't see how this could go wrong
 except by mktemp having a bug and returning a random directory, which we
 can't defend against afaict.

 I added another patch on top.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14478#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs