[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #6411 [Tor]: Adding hidden services through control socket
#6411: Adding hidden services through control socket
-------------------------+-------------------------------------------------
Reporter: | Owner: yawning
kevinevans | Status: accepted
Type: | Milestone: Tor: 0.2.7.x-final
enhancement | Version: Tor: 0.2.3.19-rc
Priority: normal | Keywords: hidden-service control maybe-
Component: Tor | proposal tor-hs globalleaks-wants
Resolution: | Parent ID: #8993
Actual Points: |
Points: |
-------------------------+-------------------------------------------------
Comment (by yawning):
The thread: https://lists.torproject.org/pipermail/tor-
dev/2015-February/008279.html
Right, so after a productive tor-dev@ thread regarding the design, I went
and made some more changes:
* Ephemeral hidden services are tied to the control port connection that
created them. This means, that when the control connection goes away, so
does the hidden service intro point. Closing client connections is left
as an exercise for the application.
* `DEL_EPH_HS` can now only remove ephemeral hidden services created on
the same control port connection. Attempts `ADD_EPH_HS` on one
connection, and `DEL_EPH_HS` on another will result in the tor disavowing
knowledge of the service in an error code.
* `ADD_EPH_HS` has a new syntax that is hopefully more futureproof.
`ADD_EPH_HS` SP keyType:keyBlob 1+(SP `Port=` VIRTPORT [`,` TARGET])
CRLF
The new syntax allows us to add other arguments to the command in the
future more easily, and as a side bonus for callers, TARGET can now be
omitted to obtain behavior identical to `HiddenServicePort` (As in, it
will default to `127.0.0.1:VIRTPORT`).
The way forward:
* Write a patch for `control-spec.txt`, documenting the new commands.
* Wait for the 0.2.7.x cycle to start.
* Get my feature branch reviewed, and fix the dumb bugs that are probably
lurking.
* Squash it down and merge.
* (In the Grim Dark Future) Revisit and think about authenticated HSes.
Tentatively, `needs_review`-ing this, since the code is done, and appears
to work.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6411#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs