[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #14859 [Onionoo]: Adapt Onionoo's parsing code for MaxMind's GeoLite2 City files to their new format
#14859: Adapt Onionoo's parsing code for MaxMind's GeoLite2 City files to their new
format
-------------------------+--------------------------
Reporter: karsten | Owner:
Type: defect | Status: needs_review
Priority: normal | Milestone:
Component: Onionoo | Version:
Resolution: | Keywords:
Actual Points: | Parent ID:
Points: |
-------------------------+--------------------------
Comment (by iwakeh):
Oh, I didn't verify ISO-8859.x. Good catch.
No other test cases unless you have the time to cover other European
accents and special characters ( {{{Ã Ã Ã Ã Ã ...}}}).
Or, instead verify the UTF8 encoding of the MaxMind files explicitly. So,
there'll be a failing test, if MaxMind changes file format?
This branch should be fine now, even without further tests.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14859#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs