[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12844 [Tor]: Allow Tor2Web mode to specify its own Rendezvous Point

#12844: Allow Tor2Web mode to specify its own Rendezvous Point
-----------------------------+----------------------------------
     Reporter:  asn          |      Owner:
         Type:  task         |     Status:  closed
     Priority:  normal       |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor          |    Version:
   Resolution:  implemented  |   Keywords:  tor-hs, nickm-review
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+----------------------------------

Comment (by arma):

 For code cleanliness, I think you don't want to check #if
 defined(ENABLE_TOR2WEB_MODE) in circuitbuild.c, but instead rely on the
 value of options->Tor2webMode, which is enforced in options_act(). That's
 what we do elsewhere in the code, e.g.
 connection_ap_handshake_rewrite_and_attach().

 I actually got snookered thinking that grepping for ENABLE_TOR2WEB_MODE
 was the way to find all the changes that are affected by tor2web mode,
 because that's how this change was enabled.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12844#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs