[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #14555 [Tor]: Clarification about new CIRC attributes
#14555: Clarification about new CIRC attributes
------------------------+--------------------------------
Reporter: atagar | Owner: arthuredelstein
Type: defect | Status: needs_review
Priority: minor | Milestone: Tor: 0.2.6.x-final
Component: Tor | Version:
Resolution: | Keywords:
Actual Points: | Parent ID:
Points: |
------------------------+--------------------------------
Comment (by arthuredelstein):
Replying to [comment:19 nickm]:
> Replying to [comment:18 atagar]:
> > > Is there a function in Tor that encodes QuotedStrings?
> >
> > We have QuotedStrings all throughout the control-spec. What do we do
for all the other instances?
>
> In some cases, the code uses esc_for_log. Others are input-only.
>
> I looked the other night and couldn't find a function that actually
encodes in QuotedString format in our code. That doesn't mean there
couldn't be one, but hey
>
> > > If we change in 0.2.6.4, will we break old TBB versions that rely on
the old behavior?
> >
> > I filed this ticket right after the attribute was added to the spec.
I'm a tad surprised it's already in a release.
>
> It's in a TBB alpha, but I don't want to make their lives harder.
If you want to change the escaping for #8405, I don't expect it will
affect TBB. We're not using any special characters for SOCKS
username/password.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14555#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs