[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18172 [Tor Browser]: Emoji support is broken in Tor Browser 5.5
#18172: Emoji support is broken in Tor Browser 5.5
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
Type: defect | team
Priority: Medium | Status:
Component: Tor Browser | needs_review
Severity: Normal | Milestone:
Keywords: tbb-fingerprinting-fonts, tbb- | Version:
usability-website, TorBrowserTeam201602R | Resolution:
Parent ID: #18097 | Actual Points:
Sponsor: | Points:
-------------------------------------------------+-------------------------
Changes (by arthuredelstein):
* status: needs_revision => needs_review
Comment:
Replying to [comment:8 gk]:
> Replying to [comment:6 arthuredelstein]:
> > Replying to [comment:4 gk]:
> > > Replying to [comment:2 arthuredelstein]:
> > > > So it looks like we need to fix Mac and Windows, but Linux is OK.
> > >
> > > That's actually not true. Surprisingly I have at least one Linux box
where emoticons are broken. Is is running Debian testing. That said I
realized that it can be a bit hard to see this if one is upgrading from
5.0.7 as it seems to work then but after shutting the browser down and
restarting it no emoticons are shown. (This reminded me at one of the
failure modes of our start script. :/)
> >
> > You're right, this happened to me. Once I shutdown the browser and
started it again, the Emojis were no longer available.
> >
> > So here's a patch for Linux:
> >
> > https://github.com/arthuredelstein/tor-browser-bundle/commit/18172
> >
> > I built this version and confirmed that the Emojis are displayed,
using the "Noto Emoji" font.
>
> I think we can start with this font as a fix for this bug. Two things
regarding the patch:
>
> 1) You don't use `NOTOEMOJIFONT_VER` anywhere, so we don't need it.
Which reminds me that the same seems to hold for `NOTOCJKFONT_VER`.
> 2) Please remove the superflous newline below `+- "NotoEmoji-
Regular.ttf"`
Here's a patch with these things fixed:
https://github.com/arthuredelstein/tor-browser-bundle/commit/18172+1
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18172#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs