[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-bugs] #18242 [Tor]: Revert no-assertions-on-coverage, or make it controlled by an option.



#18242: Revert no-assertions-on-coverage, or make it controlled by an option.
------------------------+--------------------------------
     Reporter:  nickm   |      Owner:
         Type:  defect  |     Status:  new
     Priority:  Medium  |  Milestone:  Tor: 0.2.8.x-final
    Component:  Tor     |    Version:
     Severity:  Major   |   Keywords:  TorCoreTeam201601
Actual Points:          |  Parent ID:
       Points:          |    Sponsor:
------------------------+--------------------------------
 In 1228dd293b60a we made TOR_COVERAGE equavalent to NDEBUG so that branch
 coverage could be accurate.

 But we hate  NDEBUG.

 I just spent 20 minutes too long debugging a problem because I'd forgotten
 that I was building with enable_coverage and that as such I shouldn't
 expect tor_assert to do anything.

 We should either revert 1228dd293b60a, or make an --enable-branch-coverage
 option for configure that you have to use if you want  to do branch
 coverage this way.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18242>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs