[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18240 [Tor]: 'make test-stem' yields No rule to make target '"./src/or/tor"'

#18240: 'make test-stem' yields No rule to make target '"./src/or/tor"'
--------------------+------------------------------------
 Reporter:  arma    |          Owner:
     Type:  defect  |         Status:  new
 Priority:  Medium  |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor     |        Version:
 Severity:  Normal  |     Resolution:
 Keywords:          |  Actual Points:
Parent ID:          |         Points:
  Sponsor:          |
--------------------+------------------------------------

Comment (by cypherpunks):

 Replying to [comment:5 cypherpunks]:
 > >The top_builddir variable is not necessary because Tor only has one
 Makefile and according to the Autoconf documentation this variable is
 equal to builddir (which is always ".") in the top-level directory of the
 build tree.
 >
 > This ''happens'' to be the case now.  The point is that the path is
 specified relative to the top level ("/src/or/tor").  So don't remove it,
 otherwise one would need to adjust it when/if the Makefile moves.
 The Makefile is not going to move unless Tor moves back to recursive make
 (which is unlikely to happen, for the arguments see commit
 [https://gitweb.torproject.org/tor.git/commit/?id=2a4a1496241d6c4183763f90600be4775ccb5470
 2a4a1496241d6c4183763f90600be4775ccb5470]). Iff that change happens the
 entire build configuration has to be rewritten because everything is
 currently specified relative to the top level (which can be seen in the
 include.am files).
 Additionally, the generated Makefile contains no rules that include the
 builddir for building the tor binary but it does contain the rule
 {{{
 src/or/tor$(EXEEXT): $(src_or_tor_OBJECTS) $(src_or_tor_DEPENDENCIES)
 $(EXTRA_src_or_tor_DEPENDENCIES) src/or/$(am__dirstamp)
 }}}
 For these reasons i believe the builddir can safely be removed from the
 TESTING_TOR_BINARY variable. If there are instances where this would fail,
 i'm interested in hearing about them.

 >I can't comment about EXEEXT.
 If you're interested you can read more about it in the
 [https://www.gnu.org/software/automake/manual/automake.html#EXEEXT
 Automake documentation].

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18240#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs