[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17751 [Tor]: Use router_get_my_routerinfo() rather than desc_routerinfo

#17751: Use router_get_my_routerinfo() rather than desc_routerinfo
--------------------+------------------------------------
 Reporter:  teor    |          Owner:  hkannan
     Type:  defect  |         Status:  needs_review
 Priority:  Medium  |      Milestone:  Tor: 0.2.9.x-final
Component:  Tor     |        Version:
 Severity:  Minor   |     Resolution:
 Keywords:  easy    |  Actual Points:
Parent ID:          |         Points:  small
  Sponsor:          |
--------------------+------------------------------------

Comment (by teor):

 The only behavioural change in this patch is that the following checks:
 {{{
   if (!server_mode(get_options()))
     return NULL;
   if (router_rebuild_descriptor(0))
     return NULL;
 }}}
 are now performed before accessing router_get_my_routerinfo() in:
 * check_descriptor_bandwidth_changed()
 * check_descriptor_ipaddress_changed()

 I think this is slightly better behaviour than the old code.
 (All the other changes result in the same behaviour: we were already
 calling router_get_my_routerinfo() in most of these functions before
 accessing desc_routerinfo.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17751#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs