[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17949 [Tor]: Make loopback address search more efficient

#17949: Make loopback address search more efficient
------------------------------------+------------------------------------
 Reporter:  teor                    |          Owner:  rl1987
     Type:  enhancement             |         Status:  needs_review
 Priority:  Medium                  |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor                     |        Version:
 Severity:  Normal                  |     Resolution:
 Keywords:  easy TorCoreTeam201602  |  Actual Points:
Parent ID:  #17991                  |         Points:  medium
  Sponsor:                          |
------------------------------------+------------------------------------

Comment (by teor):

 Replying to [comment:15 bugzilla]:
 > {{{int}}} for {{{bool}}}, no tests for {{{loopback != 0}}}, ok?

 We don't use `bool` anywhere else in the codebase. This isn't the place to
 start.
 And `if (loopback)` is equivalent to `if (loopback != 0)`.

 (If you really want a one-bit field, `bool` isn't sufficient, as it's 8
 bits or more. You need a one-bit bitfield in a struct. Which is more
 trouble than it's worth, unless you already have a struct.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17949#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs