[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17178 [Tor]: Rendezvous Single Onion Services: One-Hop Intro Point and Rendezvous

#17178: Rendezvous Single Onion Services: One-Hop Intro Point and Rendezvous
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
     Type:  enhancement                          |         Status:
 Priority:  High                                 |  needs_review
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  028-triaged, tor-hs,                 |        Version:
  TorCoreTeam201602                              |     Resolution:
Parent ID:                                       |  Actual Points:
  Sponsor:  SponsorU                             |         Points:  large
-------------------------------------------------+-------------------------

Comment (by asn):

 Small review.

 How come `assert_circ_onehop_ok()` is a macro? Having it as a macro makes
 it look kinda ugly and also it's hidden in a header file.

 Also, I don't entirely understand:
 {{{
     tor_assert((is_dir) || rend_allow_direct_connection((options)) || \
                (circ)->build_state->onehop_tunnel == 0); \
 }}}
 it's different than the assert that it replaced. I would suggest to spread
 it out and maybe add some comments? Or is it something trivial that I
 don't get?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17178#comment:36>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs