Re: [tor-bugs] #18235 [Tor Messenger]: Disable Facebook

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#18235: Disable Facebook
---------------------------+---------------------
 Reporter:  arlolra        |          Owner:
     Type:  defect         |         Status:  new
 Priority:  Medium         |      Milestone:
Component:  Tor Messenger  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:                 |         Points:
  Sponsor:                 |
---------------------------+---------------------

Comment (by sukhbir):

 Replying to [comment:2 arlolra]:
 > The patch looks problematic.
 >
 > If someone already has a facebook account setup, what's this patch going
 to do? It looks like it'll throw something nasty. Can you try creating a
 facebook account then applying this patch and seeing what happens

 Given that we have no updater, how will that work? This patch will go in
 the next release of Tor Messenger, on a new user profile so there will be
 no existing accounts.

 > Also, until you have gerrit setup, can you push a branch to github and
 make a pull request for review, rather than pushing to master?

 (OK from next time.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18235#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs