[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #16990 [Tor Browser]: Circuit visualizer stops working after some time
#16990: Circuit visualizer stops working after some time
-------------------------------------------------+-------------------------
Reporter: cypherpunks | Owner:
Type: defect | arthuredelstein
Priority: Medium | Status:
Component: Tor Browser | needs_review
Severity: Normal | Milestone:
Keywords: tbb-torbutton, tbb-circuit-display, | Version:
TorBrowserTeam201602 | Resolution:
Parent ID: | Actual Points:
Sponsor: | Points:
-------------------------------------------------+-------------------------
Comment (by cypherpunks):
Your patch also includes this:
{{{
@@ -113,7 +113,7 @@ io.asyncSocket = function (host, port, onInputData,
onError) {
let totalString = pendingWrites.join("");
try {
outputStream.write(totalString, totalString.length);
- log("controlPort << " + aString + "\n");
+ log("controlPort << " + aString);
} catch (err) {
onError(err);
}
}}}
Maybe you actually want it like that, but then you should notice that this
behaves differently than the complementary ">>" log. You removed the
suggested `.trim()` but this is basically what the ">>" log does, in
effect. It actually splits the message in lines, only to join them
together again, but the result is the same: the logged message does
__not__ contain the trailing "\r\n". Here you __do__ include the trailing
"\r\n". The result is that in stderr you will see an extra line feed (so
2; currently without this fix there are 3!).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16990#comment:36>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs