[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18337 [Tor]: Remove network dependencies from 0.2.8 unit tests
#18337: Remove network dependencies from 0.2.8 unit tests
-------------------------------+------------------------------------
Reporter: teor | Owner: teor
Type: defect | Status: new
Priority: Medium | Milestone: Tor: 0.2.8.x-final
Component: Tor | Version:
Severity: Normal | Resolution:
Keywords: TorCoreTeam201602 | Actual Points:
Parent ID: | Points:
Sponsor: |
-------------------------------+------------------------------------
Description changed by teor:
Old description:
> Some of the new unit tests in 0.2.8 (#17076) seem to be using the
> resolver on non-existent addresses. This causes them to be slow when the
> network is up, but fast when it's down (at least on my OS X box).
>
> mikeperry has also complained that they're slow on #17076.
>
> We could mock the address resolution functions to always return NXDOMAIN
> during these tests to make them faster.
New description:
Some of the new unit tests in 0.2.8 (#17076) seem to be using the resolver
on non-existent addresses. This causes them to be slow when the network is
up, but fast when it's down (at least on my OS X box).
mikeperry has also complained that they're slow on IRC.
We could mock the address resolution functions to always return NXDOMAIN
during these tests to make them faster.
--
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18337#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs