[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17668 [Tor]: moria1, with updated v3 cert: Bug: Generated a networkstatus consensus we couldn't parse.

#17668: moria1, with updated v3 cert: Bug: Generated a networkstatus consensus we
couldn't parse.
------------------------------------------------+--------------------------
 Reporter:  arma                                |          Owner:  nickm
     Type:  defect                              |         Status:  accepted
 Priority:  High                                |      Milestone:  Tor:
Component:  Tor                                 |  0.2.7.x-final
 Severity:  Blocker                             |        Version:
 Keywords:  201512-deferred, TorCoreTeam201602  |     Resolution:
Parent ID:                                      |  Actual Points:
  Sponsor:                                      |         Points:
------------------------------------------------+--------------------------

Comment (by Sebastian):

 typos:

 +    /* If not enough authorties listed this exact <ed,rsa> pair,

 +   * by_rsa_sha1 above. We __an__ include <NULL,RSA-SHA1> entries for
 votes that


 dir-spec: Looks fine, but I think we should include a note about needing
 to look at the consensus to verify that an ed key listed in a descriptor
 is actually valid, at least until the ed key becomes the canonical key.

 Comment from above that didn't get a reply, but I think it should:

 "Should we add asserts to the functions that say "this may only be called
 after dircollator_collate"? seems like we have the is_collated field for
 that purpose."

 lgtm otherwise!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17668#comment:36>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs