[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21443 [Metrics/CollecTor]: CollecTor does not delete exit lists after three days anymore



#21443: CollecTor does not delete exit lists after three days anymore
-------------------------------+------------------------------
 Reporter:  karsten            |          Owner:  metrics-team
     Type:  defect             |         Status:  needs_review
 Priority:  Medium             |      Milestone:
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+------------------------------

Comment (by karsten):

 Hmm, can you come up with a simple test for this bugfix?

 If not, I'd argue that fixes of recently introduced bugs don't need to be
 accompanied by tests, as opposed to enhancements.  Which probably means
 that we should have written a test when changing this code earlier, which
 might have uncovered the bug in the first place.  But really, I can see
 this trivial fix go in without test.

 And yes, modernization of this code is beyond the scope of this ticket,
 unfortunately.  We should probably think about that when adding other data
 to CollecTor, like webstats.  But that's for another day.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21443#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs