[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.
#20657: prop224: Implement service support.
-----------------------------+------------------------------------
Reporter: dgoulet | Owner: dgoulet
Type: enhancement | Status: accepted
Priority: Medium | Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-hs, prop224 | Actual Points:
Parent ID: #12424 | Points: parent
Reviewer: | Sponsor: SponsorR-must
-----------------------------+------------------------------------
Comment (by dgoulet):
Replying to [comment:7 asn]:
> I also pushed a topspec branch `prop224-time-period` which addresses
some spec issues that we identified in IRC. Please ACK it and I will merge
upstream.
Actually, after playing with the code I propose we back off on this. The
get period num function needs to do some arithmetic with the period length
and `time_t now` which if we use `uint32_t`, it gets unpleasant fast
because `time_t` on x64 is on 8 bytes so we have to check for all
over/underflow possibilities. Instead, if we keep it to `INT_8()`, we
avoid this issue entirely and it makes us also much more resilient for the
post-apocalypse 2038 :).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20657#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs