[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #21027 [Core Tor/Tor]: tor_bug_occurred_(): Bug: src/or/entrynodes.c:816: entry_guard_add_to_sample_impl: Non-fatal assertion !(have_sampled_guard_with_id(gs, rsa_id_digest)) failed. (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)
#21027: tor_bug_occurred_(): Bug: src/or/entrynodes.c:816:
entry_guard_add_to_sample_impl: Non-fatal assertion
!(have_sampled_guard_with_id(gs, rsa_id_digest)) failed. (on Tor 0.3.0.0
-alpha-dev 8b75261b6dc341de)
-------------------------------------------------+-------------------------
Reporter: asn | Owner: nickm
Type: defect | Status:
| needs_review
Priority: High | Milestone: Tor:
| 0.3.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-guard, tor-guards-revamp, | Actual Points:
regression |
Parent ID: | Points: 1
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by nickm):
Further investigation:
Fortunately, there aren't any ID->guard maps in the data structures. The
exported `entry_guard_get_by_id_digest*()` function, though, _does_ assume
that "the guard with a given RSA ID" is a well-specified concept. Nothing
outside of circpathbias.c uses it, however.
The get_sampled_guard_with_id() function (which appears to do the same
thing!) is used by have_sampled_guard_with_id() and by
get_sampled_guard_for_bridge().
So I think the right answer here is to just back off on the assumption
that RSA IDs are unique by bridges. But we'll need to have a better notion
for bridge equality, and other improved functions. Hmmmm.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21027#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs