[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21027 [Core Tor/Tor]: tor_bug_occurred_(): Bug: src/or/entrynodes.c:816: entry_guard_add_to_sample_impl: Non-fatal assertion !(have_sampled_guard_with_id(gs, rsa_id_digest)) failed. (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)

#21027: tor_bug_occurred_(): Bug: src/or/entrynodes.c:816:
entry_guard_add_to_sample_impl: Non-fatal assertion
!(have_sampled_guard_with_id(gs, rsa_id_digest)) failed. (on Tor 0.3.0.0
-alpha-dev 8b75261b6dc341de)
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-guard, tor-guards-revamp,        |  Actual Points:
  regression                                     |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Let me try to figure this one:

 {{{
  * [...] but tolerate a bridge with
  * an unknown digest if the digest is provided. */
 }}}

 If `digest` is provided, we want to "tolerate" or I guess return a bridge
 that matches addr/port *if* that bridge doesn't match the given digest?
 (the unknown is confusing, is it unset or just doesn't match the given
 digest?)

 Shouldn't that comment look like this in some "pseudo code" which seems
 very weird:

 {{{
 if (digest && bridge->identity != digest)) {
   return bridge;
 }
 }}}

 I would improve documentation on that function because it doesn't actually
 explain the "closest" in the function name nor what it actually does
 clearly.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21027#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs